Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nbf and exp claims #38

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Add support for nbf and exp claims #38

merged 1 commit into from
Mar 11, 2016

Conversation

alexjab
Copy link
Collaborator

@alexjab alexjab commented Feb 21, 2016

Hi, here is a PR for this issue (the nbf and exp claims).

Before merging, I have a question : what purpose do you intend for the noVerify option ? Should it skip signature validation and the new nbf and exp claims, or only the signature validation ?

If we choose the latter, I will need a little refactor of this PR...

For me, both of these options sound valid in their own way.

@hokaccha
Copy link
Owner

Before merging, I have a question : what purpose do you intend for the noVerify option ? Should it skip signature validation and the new nbf and exp claims, or only the signature validation ?

If noVerify is true, nbf and exp claims also should be skipped. Your code is correct 👍

hokaccha added a commit that referenced this pull request Mar 11, 2016
Add support for nbf and exp claims
@hokaccha hokaccha merged commit c9a52bb into hokaccha:master Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants