Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pandas 2.1 #1276

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Support pandas 2.1 #1276

merged 3 commits into from
Sep 11, 2023

Conversation

ianthomas23
Copy link
Member

Now that there is a SpatialPandas RC the supports Pandas 2.1 (https://pypi.org/project/spatialpandas/0.4.9rc1/#files and https://anaconda.org/pyviz/spatialpandas/files), we can remove the temporary pin of #1275.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1276 (c69d941) into main (7f43eda) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   83.53%   83.54%   +0.01%     
==========================================
  Files          35       35              
  Lines        9128     9134       +6     
==========================================
+ Hits         7625     7631       +6     
  Misses       1503     1503              
Files Changed Coverage Δ
datashader/bundling.py 98.64% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23
Copy link
Member Author

It wasn't as easy as just removing the pandas pin. There were also problems in the edge bundling code when reading rows from a Pandas DataFrame; previously the code took whatever column order it was given which is not reliable when converting column names to deal with edge_id. Now we are using the recommended df.itertuples() and specifically extracting the columns in a particular order.

All of this code looks ripe for performance improvement eventually.

@ianthomas23 ianthomas23 changed the title Remove temporary pandas 2.1 pin Support pandas 2.1 Sep 8, 2023
@ianthomas23 ianthomas23 merged commit 0f9bc32 into holoviz:main Sep 11, 2023
16 checks passed
@ianthomas23 ianthomas23 deleted the remove_pandas_2.1_pin branch September 11, 2023 09:51
@ianthomas23 ianthomas23 added this to the v0.15.3 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant