Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace np.NaN with np.nan #1289

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Replace np.NaN with np.nan #1289

merged 1 commit into from
Oct 13, 2023

Conversation

ianthomas23
Copy link
Member

Following NumPy 2.0 migration guide: https://numpy.org/devdocs/numpy_2_0_migration_guide.html

Thanks to @hoxbro for highlighting this.

@ianthomas23 ianthomas23 added this to the v0.15.3 milestone Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1289 (6572116) into main (b0e9a32) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files          52       52           
  Lines       10870    10870           
=======================================
  Hits         9319     9319           
  Misses       1551     1551           
Files Coverage Δ
datashader/core.py 88.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 615bf96 into main Oct 13, 2023
16 checks passed
@ianthomas23 ianthomas23 deleted the NaN_to_nan branch October 13, 2023 13:10
@hoxbro hoxbro mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant