Added Images class to format a list of images as an HTML table #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR, you can now do things like:
Open question: Why is the background a darker gray? And why does it highlight when the mouse hovers over it?
|
|
I think the answer to why the table version is a darker gray and why it highlights is this change to jupyter: jupyter/notebook#1776 This behavior makes sense for tables of spreadsheet-like data:
But not for tables used just for formatting purposes, as here. The relevant CSS appears to be in this file, but I'm not quite sure how to cram it into the inline styles that I can see using here. |
jbednar
added a commit
that referenced
this pull request
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Images class to format a list of images as an HTML table, to make it simpler to write notebooks and documentation for datashader. Supports labelling each image with its xarray name, and so also added support for passing name into the various ways to create the image.