Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the broken test because of the dask api-change. #667

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fix the broken test because of the dask api-change. #667

merged 1 commit into from
Nov 22, 2018

Conversation

SchoolGuy
Copy link
Contributor

Fixes: #666

@philippjfr
Copy link
Member

Thanks, looks good to me.

@philippjfr philippjfr merged commit 174e5bd into holoviz:master Nov 22, 2018
@jbednar
Copy link
Member

jbednar commented Nov 22, 2018

Thanks! I guess we don't need to add any version pinning or version checks, because we're only testing with the latest Dask, and this code is only in our tests, not our actual codebase?

@SchoolGuy
Copy link
Contributor Author

I can't say because my goal was just to fix the test. Problem is/was when setting up the dev-environment for me that my PyCharm complained about a lot of missing packages which sometimes resulted in tests failing which are actually not failing. If you like I open another PR for that. (@philippjfr @jbednar )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants