Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use of xarray objects as the input to datashader 2D functions #675

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Allow the use of xarray objects as the input to datashader 2D functions #675

merged 2 commits into from
Dec 21, 2018

Conversation

jsignell
Copy link
Member

Closes #201

@jsignell
Copy link
Member Author

@jbednar not sure if you want to review. This is pretty isolated; if the input isn't an xarray object, everything should work the same.

jbednar
jbednar approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jsignell
Copy link
Member Author

I don't have merge access. But this is good to go!

@philippjfr
Copy link
Member

Looks good to me too, I'll merge.

@philippjfr philippjfr merged commit 8dccea2 into holoviz:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsignell @philippjfr @jbednar