Fix for the gerrymandering shape file #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also removed entries that are now unused in |
|
I've added the zip file to the bucket. I'll test now and if it works, this PR is ready to review/merge. |
|
I can confirm that the gerrymandering example is now working in a fresh environment / datashader install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original link to the shape file source for the gerrymandering notebook was not reliable (see this commit) but the change introduced there did not include all the necessary files. This PR now moves the entire zip file to S3 which should be more reliable and include all the files.
Not quite ready to merge as I need to upload the zip (waiting on access permissions) at which point I'll test it is working in a clean environment.