Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for compatibility with cudf v0.10 #821

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Updates for compatibility with cudf v0.10 #821

merged 2 commits into from
Oct 31, 2019

Conversation

jonmmease
Copy link
Collaborator

Various fixes for compatibility with version cudf version 0.10

@jbednar
Copy link
Member

jbednar commented Oct 25, 2019

Which versions of cudf are now supported? Can you express that with a conditional dependency in the conda setup?

@jonmmease
Copy link
Collaborator Author

Which versions of cudf are now supported? Can you express that with a conditional dependency in the conda setup?

Good point, I'll do some tests and update the conda recipe.

@jonmmease
Copy link
Collaborator Author

Version constraint added. Unless others object, I'm going to make the lower bound 0.10.0 since cudf is still moving really fast, and these changes would require some fallback logic in order to support older versions as well.

@jbednar
Copy link
Member

jbednar commented Oct 25, 2019

I'm happy with that; if we ran into someone with a strong constraint pinning them to an older cudf version we could consider adding such support at that time, but meanwhile let's do the thing we can maintain most easily. It's tricky when we're depending on something with a version like 0.10, because by semantic versioning we've no idea whether their next releases will break anything, yet if we pin directly to 0.10 and no higher, we'll guarantee that it won't support the next release. So we're damned either way! We'll just have to quickly cut a new datashader release if the next cudf version is incompatible.

@jbednar jbednar merged commit c35f158 into master Oct 31, 2019
@maximlt maximlt deleted the cudf_0.10 branch December 25, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants