Update project and CI #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhaus
reviewed
Sep 26, 2023
| uses: pypa/gh-action-pypi-publish@v1.8.10 | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI_TOKEN }} |
There was a problem hiding this comment.
We could directly switch to Trusted Publisher to improve security
There was a problem hiding this comment.
Ah yes, can we do that in a follow up? I'm not sure how to do that with the libs org and I think the PYPI account linked is still from @balloob
edenhaus
reviewed
Sep 26, 2023
Co-authored-by: Robert Resch <robert@resch.dev>
edenhaus
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Housekeeping PR as the repo was missing a lot of linting and CI and was a bit behind in standards.
Also switched to automatic version numbering following our other libs.
Commented out pylint and mypy in the precommit config, will fix those in follow up PR(s) as it needs a bit more work on the code and this PR would be huge otherwise.