Fix Thread sync throwing exception sometimes crashing app #3634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thread credential syncing uses the provided
CoroutineScope
to run other functions that throw exceptions. An user found an issue when not connected to their home network, this will throw an exception when getting the device credentials. Depending on where the function is called, this can crash the app.When using a normal
Job
, like in themainScope
that we create in a few places, a thrown exception will mean that everything in that scope is cancelled and the exception propagates up, even if 'caught'. That isn't wanted so use aSupervisorJob
instead, like the defaultviewModelScope
, when running this function to make sure that when caught nothing else stops.Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes
Easiest way to test is to access Home Assistant while only connected to mobile data and initiating a Thread credentials sync from the app settings.