Added support for hourly percent change in coinmarketcap component #11996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kevindgoff, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant
added
cla-needed
platform: sensor.coinmarketcap
cla-signed
and removed
cla-needed
labels
Merged
ghost
added
integration: coinmarketcap
and removed
platform: sensor.coinmarketcap
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding support to return the hourly percent change of a crypto in the coinmarketcap component.
Presently, the component only supports 24 and 7 day values. Adding the support for hourly allows automation to alert the user if a coin is trending up or down within the last hour. (e.g. flash a light)
I ran this locally and values were returned successfully in the sensor.
Checklist:
The code change is tested and works locally.
Local tests with
toxrun successfully. Your PR cannot be merged unless tests passIf the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass