Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.10.6rc2 #126468

Merged
merged 20 commits into from
Sep 24, 2024
Merged

Bump aiohttp to 3.10.6rc2 #126468

merged 20 commits into from
Sep 24, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 23, 2024

Proposed change

changelog: aio-libs/aiohttp@v3.10.5...v3.10.6rc2

The big change for HA is that the cookiejar no longer does a linear search (now a heapq) to expire cookies which was a problem for us with the shared sessions because over time the cookiejar would grow and more and more run time would be spent there the longer HA was running.

Additionally the middleware performance penalty which accounted for 40-60% of the handler run time has been solved

If all goes well we should be able to release 3.10.6 during beta.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

changelog: aio-libs/aiohttp@v3.10.5...v3.10.6rc0

The big change for HA is that the cookiejar no longer does a linear
search to expire cookies which was a problem for us because over time
the cookiejar would grow and more and more run time would be spent
@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Sep 23, 2024
@bdraco bdraco marked this pull request as ready for review September 23, 2024 04:15
@bdraco bdraco requested a review from a team as a code owner September 23, 2024 04:15
@epenet
Copy link
Contributor

epenet commented Sep 23, 2024

It looks like it contains some breaking changes... a lot of tests are failing

@bdraco
Copy link
Member Author

bdraco commented Sep 23, 2024

It's our mocking missing some methods,

and there is a breaking change with unquoting match info to fix a regression aio-libs/aiohttp#5621 and it turns out the media player proxy relied on that regression Its no longer breaking for us in rc1

@bdraco
Copy link
Member Author

bdraco commented Sep 23, 2024

I think there is another issue

tracking it in aio-libs/aiohttp#9267

@bdraco
Copy link
Member Author

bdraco commented Sep 23, 2024

We need to address the regression upstream before we can move this forward

@bdraco
Copy link
Member Author

bdraco commented Sep 23, 2024

aio-libs/aiohttp#9271 cooking now

@bdraco bdraco changed the title Bump aiohttp to 3.10.6rc0 Bump aiohttp to 3.10.6rc1 Sep 23, 2024
@bdraco
Copy link
Member Author

bdraco commented Sep 23, 2024

Tests pass now. Everything looks good..

... but the wheels won't build

@bdraco
Copy link
Member Author

bdraco commented Sep 23, 2024

ERROR: Cannot install aiohttp==3.10.6rc1 because these package versions have conflicting dependencies.

The conflict is caused by:
The user requested aiohttp==3.10.6rc1
The user requested (constraint) aiohttp==3.10.6rc1

@bdraco
Copy link
Member Author

bdraco commented Sep 24, 2024

The pypi upload only uploaded some of the wheels.

Was good enough to get a clean run though so proceeding to release.

@bdraco
Copy link
Member Author

bdraco commented Sep 24, 2024

We decided to delay the release to fix a display issue with the docs via aio-libs/aiohttp-theme#61 so

I'll get rc2 aio-libs/aiohttp#9273 published instead so we can bump here since rc1 failed to upload the source tarball because GitHub was being flakey

@bdraco bdraco changed the title Bump aiohttp to 3.10.6rc1 Bump aiohttp to 3.10.6rc2 Sep 24, 2024
@bdraco bdraco marked this pull request as ready for review September 24, 2024 02:55
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 3120004 into dev Sep 24, 2024
44 checks passed
@frenck frenck deleted the aiohttp_3106rc0 branch September 24, 2024 06:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants