Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hvac modes back to opentherm #25268

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Add hvac modes back to opentherm #25268

merged 1 commit into from
Jul 18, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Jul 18, 2019

Description:

Add hvac_modes to opentherm. Empty as it does not support setting it?

Fixes #25239

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.96.1 milestone Jul 18, 2019
@ghost
Copy link

ghost commented Jul 18, 2019

Hey there @mvn23, mind taking a look at this pull request as its been labeled with a integration (opentherm_gw) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@pvizeli pvizeli merged commit 53954d6 into dev Jul 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the opentherm-hvac-modes branch July 18, 2019 19:32
balloob added a commit that referenced this pull request Jul 18, 2019
@balloob balloob mentioned this pull request Jul 18, 2019
@lock lock bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opentherm_gw issue: NotImplementedError
4 participants