Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to SolarEdge local documentation #13125

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

drobtravels
Copy link
Contributor

This integration no longer functions with recent firmware updates. It may continue work long term on inverters which do not receive firmware updates

More details in this issue

Proposed change

Add warning and reference to issue with more details so users can quickly determine if this integration will work for them.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • [ X] Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • [ X]This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [ X] The documentation follows the Home Assistant documentation standards.

Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Apr 22, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an alert on alerts.home-assistant.io?

@drobtravels
Copy link
Contributor Author

Thanks for reviewing. I'm unclear if any action is required by me on this? I see changes have been requested, but it looks like they were already applied.

I can add an alert to the PR if you would like. I was unfamiliar with that site. Note that this has been an issue for a long time, but I just got around to adding an update.

@frenck frenck self-assigned this May 8, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @drobtravels!

I've adjusted a bit and moved the warning a bit down (let's start with an introduction before serving the user a warning 😉 )

@frenck frenck merged commit f22653d into home-assistant:current Jun 22, 2020
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants