Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flux stop_time default. #4553

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

infernix
Copy link
Contributor

@infernix infernix commented Jan 30, 2018

Description:

Updated docs for stop_time being set to dusk by default (needs below PR before merge!).

Pull request in home-assistant (if applicable): home-assistant/core#12062>

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the [standards][standards].

@fabaff fabaff changed the base branch from current to next January 31, 2018 11:01
@fabaff fabaff changed the base branch from next to current January 31, 2018 11:01
fabaff
fabaff previously approved these changes Jan 31, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jan 31, 2018
@fabaff fabaff added this to the 0.63 milestone Jan 31, 2018
@fabaff
Copy link
Member

fabaff commented Jan 31, 2018

This PR was created against the wrong branch (current instead of next).

@infernix
Copy link
Contributor Author

The PR template says:

Fixes, changes and adjustments should be created against current

This consist of a change, does it not?

@infernix
Copy link
Contributor Author

Rebased against next. The PR template is a bit confusing though; I guess I don't consider it a new feature whereas you do :)

@frenck frenck self-assigned this Feb 8, 2018
@frenck frenck removed this from the 0.63 milestone Feb 8, 2018
@frenck
Copy link
Member

frenck commented Feb 8, 2018

Thanks for rebasing @infernix!

It is a bit confusing, but since the Home Assistant source code changes are in the dev branch, it will be released in the next release. So, the documentation should be on the next branch.

Removed milestone, since it can be merged before the actual release.

@frenck frenck merged commit 83c51eb into home-assistant:next Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature This PR adds documentation for a new Home Assistant feature to an existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants