WIP: Multiple Namespaces

[victor-homedepot]

This is to address issue #128.

• Deprecates the namespace field

• Introduces namespaces field to replace namespace

• Gracefully handles usage of deprecated field

• Updates to ginkgo v2

• Tests

• Swagger Updated

• Create new Table (see issue for details)

[guido9j]

@billiford Can you review this PR? Thanks

[billiford]

I don't see where we're actually utilizing the new Namespaces array, for example in deploy.go/patch.go, etc. Anything that references provider.Namespace now needs to references provider.Namespaces.

[guido9j]

LGTM!

[alice485]

@billiford can you re-review? I've made the changes you requested

[billiford]

I still don't see where we're referencing the new Namespaces array. For example, in internal/kubernetes/provider.go on line 67 I see

if p.Namespace != nil {
	for _, value := range clusterScopedKinds {
		if strings.EqualFold(value, kind) {
			return fmt.Errorf("namespace-scoped account not allowed to access cluster-scoped kind: '%s'", kind)
		}
	}
}

When this should say if len(provider.Namespaces) > 0. I would just comment out the Namespace field to see where all it is used and change the logic accordingly.

[alice485]

@billiford are you sure you're looking at the right version of the code? That file was already updated to reference len(p.Namespaces). It does also check p.Namespace there which I think Victor left in but I can take it out since it does end up being redundant.

go-clouddriver/internal/kubernetes/provider.go

Line 77 in 76a020b

if p.Namespace == nil && len(p.Namespaces) == 0 {

[billiford]

My bad, I was merging from the wrong branch.

[billiford]

LGTM!