fix versioning broken when deploying to multiple clusters with same artifact #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 9, 2023 13:34
…2455-go-clouddriver-versioning-broken-when-deploying-to-multiple-clusters-with-same-artifact
alice485
deleted the
CN-2455-go-clouddriver-versioning-broken-when-deploying-to-multiple-clusters-with-same-artifact
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a function
isBindablewhich validates that an artifact's provider account is the same as the account passed in with the deployment request. TheBindArtifactsfunction uses this to exclude artifacts that don't exist in the target cluster, thus preventing the behavior detailed in this issue which was causing certain deployments to fail.I also updated the unit tests to verify the expected behavior.
Tests without the bug fix:
Tests with the bug fix: