Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid error when using TRACE method #175

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

usualoma
Copy link
Member

fixes #167

The Request object defined in undici is an error if we try to create it by specifying the TRACE method. In this pull request, create it by specifying the GET method to avoid this.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

The Request object defined in undici is an error if we try to create it by specifying the TRACE method.

Ah, I see! Thanks!

@yusukebe yusukebe merged commit 05165c6 into honojs:main Jun 13, 2024
4 checks passed
nicolewhite pushed a commit to autoblocksai/cli that referenced this pull request Jun 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@hono/node-server](https://github.com/honojs/node-server) |
[`1.11.2` ->
`1.11.4`](https://renovatebot.com/diffs/npm/@hono%2fnode-server/1.11.2/1.11.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@hono%2fnode-server/1.11.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@hono%2fnode-server/1.11.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@hono%2fnode-server/1.11.2/1.11.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@hono%2fnode-server/1.11.2/1.11.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/node-server (@&#8203;hono/node-server)</summary>

###
[`v1.11.4`](https://github.com/honojs/node-server/releases/tag/v1.11.4)

[Compare
Source](https://github.com/honojs/node-server/compare/v1.11.3...v1.11.4)

#### What's Changed

- Expose ServerType from './types' by
[@&#8203;raighneweng](https://github.com/raighneweng) in
[honojs/node-server#178

#### New Contributors

- [@&#8203;raighneweng](https://github.com/raighneweng) made their
first contribution in
[honojs/node-server#178

**Full Changelog**:
honojs/node-server@v1.11.3...v1.11.4

###
[`v1.11.3`](https://github.com/honojs/node-server/releases/tag/v1.11.3)

[Compare
Source](https://github.com/honojs/node-server/compare/v1.11.2...v1.11.3)

#### What's Changed

- Update readme with an example of proper "root" when using serveStatic
by [@&#8203;brettimus](https://github.com/brettimus) in
[honojs/node-server#173
- fix: avoid error when using TRACE method by
[@&#8203;usualoma](https://github.com/usualoma) in
[honojs/node-server#175

#### New Contributors

- [@&#8203;brettimus](https://github.com/brettimus) made their first
contribution in
[honojs/node-server#173

**Full Changelog**:
honojs/node-server@v1.11.2...v1.11.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP TRACE method crashes server
2 participants