Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPD-12385 Add Hadoop File System extended attributes support. #9

Open
wants to merge 1 commit into
base: HDP-3.1.5.1
Choose a base branch
from

Conversation

mukund-thakur
Copy link

Tested by by building the gcs connector shaded jar locally and putting it into hadoop packaged local distribution. Then ran the command which was failing for the customer.
hadoop fs -Dgoogle.cloud.auth.service.account.enable=true -Dgoogle.cloud.auth.service.account.json.keyfile=gcs_service_account_keyfile.json
-setfattr -n foo -v bar gs://2bc51c33-2800-0b09-0137-4ba34f822fc6/test.txt

	Change on 2019/02/13 by idv <idv@google.com>

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=233877650

 Conflicts:
	gcs/CHANGES.txt
	gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/GoogleHadoopFileSystemBase.java
@sidseth
Copy link

sidseth commented May 18, 2020

Isn't HDP-3.1.5 getting a new version of GCS - 1.9.17?. Does that not have this patch. Otherwise, is there a jira to go with this (HOTFIX maybe?)

@mukund-thakur
Copy link
Author

QE doesn't have bandwidth to test GCS-1.9.17. So yes we are going with Hotfix approach.
https://jira.cloudera.com/browse/CDPD-12385
CC @shwethags

@mukund-thakur mukund-thakur changed the title Add Hadoop File System extended attributes support. CDPD-12385 Add Hadoop File System extended attributes support. May 19, 2020
@shwethags
Copy link

We don't have any QE support for the hotfixes. So, lets go ahead with just xattrs backport for both hotfix 3.1.5.1.2 and 3.1-maint (unless there is some imp fix in 1.9.17).
For cdpd-master, we can upgrade to 2.1.2

@sidseth
Copy link

sidseth commented May 20, 2020

I have a preference for using 1.9.17 as is - via the HOTFIX process. There's a few potential perf improvements, and some default config changes. The version this patch was introduced in was marked as 'do-not-use' (doubt this change triggered that though).

That said, if you guys want to get this in as is. +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants