Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit space available to usernames on the header #4759

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Limit space available to usernames on the header #4759

merged 1 commit into from
Jun 18, 2021

Conversation

willemarcel
Copy link
Contributor

OSM allows up to 255 characters in the username. It's better to limit the space and avoid the style from breaking

Before:

image

With the PR:

image

@willemarcel willemarcel added this to the v4.4.9 milestone Jun 17, 2021
@willemarcel willemarcel requested a review from d-rita June 17, 2021 18:17
@willemarcel willemarcel added Difficulty: 3 type: enhancement Improving an existing functionality labels Jun 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@willemarcel willemarcel added the UX label Jun 18, 2021
@willemarcel willemarcel merged commit 16a4b3f into develop Jun 18, 2021
@willemarcel willemarcel deleted the fix/username-space-limit branch June 18, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-rita d-rita d-rita approved these changes

Assignees
No one assigned
Labels
scope: frontend type: enhancement Improving an existing functionality
Projects
None yet
Milestone
v4.4.9
Development

Successfully merging this pull request may close these issues.
2 participants
@willemarcel @d-rita