Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize mutable RDS database settings #4945

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Parameterize mutable RDS database settings #4945

merged 3 commits into from
Feb 10, 2022

Conversation

eternaltyro
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dakotabenjamin
dakotabenjamin approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@dakotabenjamin dakotabenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here do not disrupt the current RDS, so no added risk to the db during deployment. Looks good.

@dakotabenjamin dakotabenjamin merged commit 5653cb1 into develop Feb 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dakotabenjamin dakotabenjamin mentioned this pull request Feb 10, 2022
Merged
@eternaltyro eternaltyro deleted the enhance/parameterize-db-settings branch February 10, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakotabenjamin dakotabenjamin dakotabenjamin approved these changes

Assignees
No one assigned
Labels
scope: infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eternaltyro @dakotabenjamin