Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy dependency updates #5937

Merged

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Jun 22, 2023

This updates dependencies and dependencies of dependencies ("deep" dependencies) that do not require code modification.

Let me know if I need to squash the commits; they were done dependency-by-dependency to make bisecting problems easier.

Not all dependencies and their deep dependencies were updated. Specifically @testing-library/jest-dom and @testing-library/react dependencies were not updated because it caused dom-accessibility-api to be updated to a known-bad version (for us).

tsmock added 30 commits June 22, 2023 05:35
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…r intl included))

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…nd date-fns)

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…te-fns)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…pdated to 3.x for MSIE compatibility reasons, revisit once polyfills are dropped)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…ccordion)

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…ndencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…r dependencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…cies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…dencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…cies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…language dependencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
tsmock added 12 commits June 22, 2023 05:35
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…iewport)

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
…ies-languages dependencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…geocoder dependencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…pendencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…ncies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…encies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…tangle-mode dependencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
…eact-hooks dependencies)

Signed-off-by: Taylor Smock <tsmock@meta.com>
@github-actions github-actions bot added scope: frontend dependencies Pull requests that update a dependency file javascript labels Jun 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@tsmock tsmock marked this pull request as ready for review June 23, 2023 13:12
@tsmock
Copy link
Contributor Author

tsmock commented Jun 23, 2023

I've done multiple test runs, and I have seen some test failures. Those test failures also occurred on a Raspberry Pi with the develop branch (see #5721, look for "Test runs #5721" subheading "RPi (Node 16, develop)").

Since I've been doing other things while running tests (like profiling JOSM), it is highly likely that there is some undefined performance point whereby test failures will start occurring reliably with current develop code.

@HelNershingThapa
Copy link
Contributor

Created branch https://github.com/hotosm/tasking-manager/tree/chore/easy-dependency-updates to run test cases; they pass.

@HelNershingThapa HelNershingThapa merged commit 700313b into hotosm:develop Jun 27, 2023
3 checks passed
@tsmock tsmock deleted the chore/easy-dependency-updates branch July 5, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants