Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ faster load project list with no map omit #6289

Conversation

varun2948
Copy link
Contributor

@varun2948 varun2948 commented Mar 18, 2024

What does this PR do ?

  • Enhances Project Lists Page Project List API and overall execution time, when Map is not turned on.

Consideration

  • On previous approach , We were using project list api without omitMapResults true and even if the map was not open, It was still fetching all the geojson of projects.
  • Current approach : We are using omitMapResults params so that when we don't need geojson we can only fetch the project related data and only fetch geojson when the map is turned on.

How to test ?

  • Try using the projectlist page it's response time has decreased and projects card loads faster.

Screenshot

image

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@varun2948
Copy link
Contributor Author

@ramyaragupathy we are having issue on github action any idea, what could it be ?

@ramyaragupathy
Copy link
Member

Following up w/ @eternaltyro @dakotabenjamin

@dakotabenjamin
Copy link
Member

we can safely ignore the failure. GitHub actions won't allow an image to be pushed from a forked repository.

@ramyaragupathy ramyaragupathy added this to the v4.7.1 milestone Mar 21, 2024
@ramyaragupathy ramyaragupathy merged commit 22f2c73 into hotosm:develop Mar 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants