Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communicate Visit direction with html[data-turbo-visit-direction] #1007

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Communicate Visit direction with html[data-turbo-visit-direction] #1007

merged 9 commits into from
Dec 4, 2023

Commits on Sep 14, 2023

  1. Add direction detail to turbo:visit events

    @domchristie
    domchristie committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    050fe38 View commit details
    Browse the repository at this point in the history

  2. Test restorationIndex is persisted between reloads

    @domchristie
    domchristie committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3111416 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Add data-turbo-visit-direction to html element

    @domchristie
    domchristie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c39c223 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Versatile Visit direction API. 

    Use html[data-turbo-visit-direction] attribute to communicate visit direction rather than using an event detail
    @domchristie
    domchristie committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    badfd69 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Remove "test" prefix from test description

    @domchristie
    domchristie committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    319adf2 View commit details
    Browse the repository at this point in the history

  2. Fix typos

    @domchristie
    domchristie committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6912e88 View commit details
    Browse the repository at this point in the history

  3. Remove "test" prefix from test description

    @domchristie
    domchristie committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2bc7c13 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Clean up assertions

    @afcapel @domchristie
    afcapel authored and domchristie committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    70cda68 View commit details
    Browse the repository at this point in the history

  2. Read the mutation logs to assert the direction attribute change 

    It's less dependent on the timing of the mutation. Even if the attribute
is no longer present, we can still assert that it was present at some
point.
    @afcapel @domchristie
    afcapel authored and domchristie committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    c6f82a5 View commit details
    Browse the repository at this point in the history