Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a turbo:before-add-element event when adding a new node #1204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

coorasse
Copy link
Contributor

While implementing some animations on our page, we realized that we had no access to an event before an element was added to the DOM.
With this PR I'd like an early feedback from maintainers if this is the right direction and I can continue.
In particular regarding the event name.

If I get your OK, I'll:

  • add tests
  • update documentation to include this new event

Let me know 🙏

@coorasse coorasse force-pushed the trigger-event-for-new-nodes branch from 0d94e70 to 8388a21 Compare March 5, 2024 09:19
@coorasse coorasse force-pushed the trigger-event-for-new-nodes branch from 8388a21 to 1b165ad Compare March 5, 2024 11:12
@coorasse coorasse changed the title Trigger an event when adding a new node Trigger a turbo:before-add-element event when adding a new node Mar 5, 2024
@coorasse
Copy link
Contributor Author

I'd love to get a feedback on this one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant