Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors.yml #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update authors.yml #4

wants to merge 1 commit into from

Conversation

hpcnotes
Copy link

@hpcnotes hpcnotes commented Jan 9, 2023

No description provided.

@vsoch
Copy link
Contributor

vsoch commented Jan 9, 2023

Taking a look!

@vsoch
Copy link
Contributor

vsoch commented Jan 9, 2023

Heyo! So it looks like you cloned the wrong blog? https://github.com/hpcnotes/blog.hpc.social The clone should be for the personal blog here. Let me know if you want to redo the PR, or if you'd like me to add for you.

@hpcnotes
Copy link
Author

hpcnotes commented Jan 9, 2023

Let me try again (in order to learn - I've actually only ever used github for reading stuff before, never contributing!)

@vsoch
Copy link
Contributor

vsoch commented Jan 9, 2023

Awesome! Ok I’m here to help if you need.

@hpcnotes
Copy link
Author

hpcnotes commented Jan 9, 2023

Ok, I looked again - the links in the instructions at the bottom of https://hpc.social/blog/ point you to fork the top level blog - presumably before it was split into personal and community blogs - so my first fork was to https://github.com/hpcnotes/blog.hpc.social as you noted - but once I figured out that doesn't actually have a _data/authors file, I then forked the personal blog https://github.com/hpc-social/personal-blog to https://github.com/hpcnotes/hpc-social-personal-blog ... and hopefully that is where I made my edit and pull request from?

@vsoch
Copy link
Contributor

vsoch commented Jan 9, 2023

It's correct that the links on that page should direct to the main blogs page - that's the central place with instructions to not need to write them in multiple. What I'll do is add a clarifying point here:

image

that the clone is NOT for the portal repo there, but the blog they have chosen in the step above.

And yes - if you fork and PR from the personal-blog that is correct!

@vsoch
Copy link
Contributor

vsoch commented Jan 9, 2023

OK warning / note added with an emoji emphasis!
image

@hpcnotes
Copy link
Author

hpcnotes commented Jan 9, 2023

OK, thanks, that makes more sense - big yellow stickers for people like me :-)

@vsoch
Copy link
Contributor

vsoch commented Jan 9, 2023

OK, thanks, that makes more sense - big yellow stickers for people like me :-)

And me too! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants