Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fp8] Disable all_gather intranode. Disable Redundant all_gather fp8 #6059

Merged
merged 8 commits into from
Sep 14, 2024

Conversation

GuangyaoZhang
Copy link
Contributor

@GuangyaoZhang GuangyaoZhang commented Sep 11, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

resolved #6058

📝 What does this PR do?

Disable all_gather_fp8 in intranode, and disable all_gather intranode. Disable Redundant all_gather fp8

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@GuangyaoZhang GuangyaoZhang marked this pull request as ready for review September 11, 2024 09:37
@GuangyaoZhang GuangyaoZhang requested a review from a team as a code owner September 11, 2024 09:37
@GuangyaoZhang GuangyaoZhang changed the title [fp8] Disable all_gather_fp8 in intranode [fp8] Disable all_gather intranode. Disable Redundant all_gather fp8 Sep 13, 2024
@ver217 ver217 merged commit f20b066 into hpcaitech:main Sep 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Disable all_gather intranode. Disable Redundant all_gather fp8
2 participants