This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
polish code and add setup script #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
juncongmoo
commented
Mar 7, 2023
juncongmoo
commented
- polish code
- add setup script
- upgrade version to 0.0.2
|
It is safe to approve. Please let me know if there is anything I need to change. Just want to help... |
|
Hi @juncongmoo Thanks so much for your contribution! |
ver217
reviewed
Mar 20, 2023
| omegaconf | ||
| hiq-python |
There was a problem hiding this comment.
Oh. I was using hiq to benchmark the fastapi servers in examples folder and planning to submit several more PRs after this one were merged. One example is:
I tried to revert to remove hiq but found I need to write many tedious functions to do the same thing, so I kept it there, also considering it is a very friendly library :-).
If you think we should remove it, I will come back two days later to remove it because I am really busy on something else right now. Thank you.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.