Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fsnotify repository relocation #138

Merged
merged 1 commit into from
May 14, 2018
Merged

Conversation

promiseofcake
Copy link
Contributor

@promiseofcake promiseofcake commented Mar 21, 2018

The https://github.com/go-fsnotify/fsnotify redirect has been disabled and replaced with an empty repo, the new path for gopkg.in is: http://gopkg.in/fsnotify/fsnotify.v1 as of yesterday.

  • Modify fsnotify import paths to: gopkg.in/fsnotify/fsnotify.v1
  • Copy vendor/fsnotify.v1 to the new import path

@promiseofcake
Copy link
Contributor Author

Fixes #136

@c9s c9s mentioned this pull request Mar 21, 2018
@c9s
Copy link

c9s commented Mar 21, 2018

@Nino-K can we merge this PR asap ? the build is now broken, we can't deliver the release and the CI is not working now...

@idanya
Copy link

idanya commented Mar 22, 2018

any news on that merge? Really need this to release ....

@promiseofcake
Copy link
Contributor Author

@idanya, @c9s, depending on your build system you should be able to use the pre-merge commit from our public fork by modifying your repo param (glide), source override (dep) or something similar for other package tools, ie for Bazel:

go_repository(
  name = "com_github_hpcloud_tail",
  importpath = "github.com/hpcloud/tail",
  remote = "git@github.com:vsco/tail.git",
  vcs = "git",
  commit = "000912af8de2d2b9d184786b4cf4c3542b7884e5"
)

@idanya
Copy link

idanya commented Mar 22, 2018

Yes, I'm using govendor and already did the same (forked and merged your commit). I'd rather it be merged here but I guess that will do for now :\

@c9s
Copy link

c9s commented Mar 25, 2018

Please merge.... it's totally broken now

@kyleconroy
Copy link

kyleconroy commented Mar 26, 2018

If you're using dep, add the following to your Gopkg.toml:

[[override]]
  name = "github.com/hpcloud/tail"
  source = "https://github.com/vsco/tail.git"
  revision = "000912af8de2d2b9d184786b4cf4c3542b7884e5"

@mattayes
Copy link

@florindragos Are you the only person with write-access to this project?

@mattayes
Copy link

mattayes commented Apr 2, 2018

@promiseofcake The fsnotify project prefers github.com/fsnotify/fsnotify to the gopkg.in link: https://godoc.org/github.com/fsnotify/fsnotify.

@promiseofcake
Copy link
Contributor Author

@mattayes, thanks for the link. In order to not conflate changes, I would be more than happy to make that change once we get this merged in.

@samkreter
Copy link

+1 on this merging. This is blocking a few deployments.

@s7v7nislands
Copy link

any update?

@mattayes
Copy link

@Nino-K do you still have write access to this repo/time to review this?

@samkreter
Copy link

This is a key blocker right now. Any estimate on when it can be merged?

@tcolgate
Copy link

This also blocks use of hpcloud/tail with vgo (at least I've been unable to get it working)

@promiseofcake
Copy link
Contributor Author

@sergei-utinski, do you know anyone who can help us out?

@sutinski sutinski merged commit a1dbeea into hpcloud:master May 14, 2018
@promiseofcake promiseofcake deleted the ljk/fix-fsnotify branch May 16, 2018 21:03
@promiseofcake
Copy link
Contributor Author

Thanks @sergei-utinski! What are the plans for this repo? Can community members get write access, or should we look into housing this repo somewhere else?

pariseed pushed a commit to pariseed/tail that referenced this pull request Oct 20, 2020
Fix fsnotify repository relocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants