Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/free text #545

Merged
merged 46 commits into from
Jan 24, 2024
Merged

Feat/free text #545

merged 46 commits into from
Jan 24, 2024

Conversation

johannesvedder
Copy link
Contributor

@johannesvedder johannesvedder commented Dec 8, 2023 •
edited
Loading

This implements a free text field for the questionnaire

Depends on

Further Feature as Issue

  • Implement Screener Question logic for Free Text

@johannesvedder johannesvedder linked an issue Dec 8, 2023 that may be closed by this pull request
Feature: Allow free text answers as outcomes #451
Closed
@github-actions github-actions bot added dependencies Pull requests that update a dependency file app core designer_v2 labels Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit ebf377b):

(expires Wed, 31 Jan 2024 10:42:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 9, 2023
@johannesvedder johannesvedder mentioned this pull request Dec 9, 2023
Closed
@hig-dev hig-dev mentioned this pull request Jan 17, 2024
Closed
hig-dev
hig-dev requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@hig-dev hig-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I tested the designer and app and it works.

core/lib/src/util/analytics.dart Outdated Show resolved Hide resolved
app/lib/screens/study/tasks/observation/questionnaire_task_widget.dart Outdated Show resolved Hide resolved
app/lib/screens/study/tasks/observation/questionnaire_task_widget.dart Outdated Show resolved Hide resolved
app/lib/screens/study/tasks/task_screen.dart Outdated Show resolved Hide resolved
app/lib/screens/study/tasks/task_screen.dart Outdated Show resolved Hide resolved
app/lib/widgets/questionnaire/questions/free_text_question_widget.dart Outdated Show resolved Hide resolved
app/lib/widgets/questionnaire/questions/free_text_question_widget.dart Outdated Show resolved Hide resolved
...v2/lib/features/design/shared/questionnaire/question/types/free_text_question_form_view.dart Outdated Show resolved Hide resolved
designer_v2/lib/localization/app_en.arb Outdated Show resolved Hide resolved
designer_v2/lib/localization/app_de.arb Outdated Show resolved Hide resolved
@johannesvedder
Copy link
Contributor Author

Thanks for the review @hig-dev. Let's merge #561 first.

@johannesvedder johannesvedder requested review from hig-dev and removed request for hig-dev January 23, 2024 10:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

johannesvedder and others added 24 commits January 24, 2024 11:37
@johannesvedder
fix: free text show errors only when dirty
d084111
@johannesvedder
refactor: enable cache again and add new logger
e0ad446
@johannesvedder
chore: format
d10252c
@johannesvedder
docs: update UML documentation
ac4de5a
@johannesvedder
chore: translation
ae3e03a
@johannesvedder
feat: improve translation
c4b9f1e
@johannesvedder
feat: increase max free text range
5b288ca
@johannesvedder
chore: lock files
1a1538c
@johannesvedder
fix: free text form fields
b2badeb
@johannesvedder
fix: quickfix for free text eligibility
5bb2e42
@johannesvedder
docs: update UML documentation
1b04eaf
@johannesvedder
chore: newline
73c3964
@johannesvedder
chore: format
057442f
@johannesvedder
docs: update UML documentation
9f1842c
@johannesvedder
fix: do not show length as double
76704bd
@johannesvedder
chore: add l10n-missing.txt
a6fc944
@johannesvedder
refactor: rename analytics
98386b0
@johannesvedder
fix: resolve suggestions
e3584b7
@johannesvedder
chore: format
8347c68
@johannesvedder
docs: update UML documentation
c2ba167
@hig-dev @johannesvedder
feat: use workaround to always show value indicator for range slider
61a06ad
@johannesvedder
docs: update UML documentation
cff0ff3
@johannesvedder
style: rangeslider label color
7c35f61
@johannesvedder
docs: update UML documentation
0dbfa52
@johannesvedder johannesvedder mentioned this pull request Jan 24, 2024
Open
@johannesvedder johannesvedder merged commit 8278e67 into dev Jan 24, 2024
11 checks passed
@johannesvedder johannesvedder deleted the feat/free-text branch January 24, 2024 10:45
@johannesvedder johannesvedder mentioned this pull request Mar 6, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hig-dev hig-dev hig-dev approved these changes

Assignees

@johannesvedder johannesvedder

Labels
app core dependencies Pull requests that update a dependency file designer_v2 documentation Improvements or additions to documentation flutter_common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Allow free text answers as outcomes
2 participants
@johannesvedder @hig-dev