Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading libopenfhe_julia_jll when using a custom library #50

Merged

Conversation

ArseniyKholod
Copy link
Collaborator

@ArseniyKholod ArseniyKholod commented May 1, 2024

I tried out your suggestion from #46. It works fine on windows and linux, with and without custom library. I tried out to find in the internet whether it's a good programming practice to load package optionally, I didn't find any cons of such approach. I think it's better than apply code formatting like was done hpsc-lab/openfhe-julia#35 (comment)). So I would suggest to merge this changes. :)

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e573ff5) to head (3150fdc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           36        36           
=========================================
  Hits            36        36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArseniyKholod ArseniyKholod linked an issue May 1, 2024 that may be closed by this pull request
@ArseniyKholod ArseniyKholod requested a review from sloede May 1, 2024 14:06
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I only suggest to add a comment such that in the future we are not wondering why we chose this particular implementation.

src/OpenFHE.jl Show resolved Hide resolved
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@sloede sloede enabled auto-merge (squash) May 2, 2024 06:58
@sloede sloede merged commit 919e8f6 into hpsc-lab:main May 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid loading libopenfhe_julia_jll when using a custom library
2 participants