Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mpeg:Only allow firmware >= 3 for warmup #13999

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Mpeg:Only allow firmware >= 3 for warmup #13999

merged 2 commits into from
Jan 29, 2021

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Jan 29, 2021 •
edited
Loading

Fix #13996

edit :and delete warmup in sceMpegGetAtracAu

hrydgard
hrydgard reviewed Jan 29, 2021
View reviewed changes
Core/HLE/sceMpeg.cpp Outdated
@@ -34,6 +34,7 @@
#include "Core/Reporting.h"
#include "GPU/GPUInterface.h"
#include "GPU/GPUState.h"
#include "CORE/HLE/sceKernelMemory.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed to "Core/HLE/sceKernelMemory.h" . Some systems are case sensitive.

@hrydgard
Copy link
Owner

Is this supported by testing on hw? I think this is a reasonably safe change anyway, just wondering.

@hrydgard hrydgard added the PSMF / MPEG Issue involves scePsmf or sceMpeg video playback. label Jan 29, 2021
@hrydgard hrydgard added this to the v1.11.0 milestone Jan 29, 2021
@sum2012
Copy link
Collaborator Author

sum2012 commented Jan 29, 2021

God eater don't give JPCSPTrace .
MegaMan power up firmware 2.6
Street Supremacy firmware 2.5
So that I give limit in firmware 3.0

@hrydgard
Copy link
Owner

OK, sounds reasonable.

@sum2012
Copy link
Collaborator Author

sum2012 commented Jan 29, 2021 •
edited
Loading

EA Replay firmware 2.71
After Burner Black Falcon USA firmware 2.82
edit2:Final Fantasy tactics Firmware 3.0.3 the game work without this change

@hrydgard hrydgard merged commit 5484907 into hrydgard:master Jan 29, 2021
@sum2012 sum2012 deleted the mpeg_minor branch January 29, 2021 23:00
@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Jan 30, 2021 •
edited
Loading

I think this is fine given how long we haven't had the warm up. I remember testing and trying to simulate it before, and it was tricky. I think it might actually have to do more with timing than number of calls, but I haven't tried testing again in a few years now...

-[Unknown]

@sum2012
Copy link
Collaborator Author

sum2012 commented Jan 30, 2021

I gave some test for more warm up test for other user for mpeg issue ,he said that my change is like frame skip 1 effect.....

@sum2012 sum2012 mentioned this pull request Jan 31, 2021
Closed
@Anuskuss Anuskuss mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrydgard hrydgard hrydgard left review comments

Assignees
No one assigned
Labels
PSMF / MPEG Issue involves scePsmf or sceMpeg video playback.
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Street Supremacy [ULUS10069] - black screen on latest nightly
3 participants
@sum2012 @hrydgard @unknownbrackets