Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install Git in Docker container #53

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix: install Git in Docker container #53

merged 1 commit into from
Jun 22, 2023

Conversation

jdblischak
Copy link
Contributor

Instructions

Thanks for contributing! ❤️

Keep in mind that lesson maintainers are volunteers and it may take them some time to respond to your contribution.
To ensure that the right people get notified, you can tag some of the last contributors with @githubname.

Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact the HSF training convenors (contacts here).

You may delete these instructions from your pull request.

- HSF Training

In order to clone the CLI11 repository in the second episode, Building with CMake, Git needs to be installed inside the Docker container

@welcome
Copy link

welcome bot commented Jun 22, 2023

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

@henryiii henryiii merged commit 9905759 into hsf-training:gh-pages Jun 22, 2023
3 checks passed
@welcome
Copy link

welcome bot commented Jun 22, 2023

Congrats on merging your first pull request 🎉! We greatly appreciate it.
You might be eligible to be added to the HSF Training Community page (see the instructions on the page for how to create a profile). If you already have created a profile previously, make sure you're also added to the current year. If this repository features a list of contributors at the bottom of the readme, you might also be eligible to add yourself there.

@henryiii
Copy link
Collaborator

Thanks!

@jdblischak jdblischak deleted the docker-install-git branch June 22, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants