Add is and as support for std::expected (v2)
#971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
reviewed
Feb 7, 2024
|
@bluetarpmedia i will take a look after a decision on how to implement is and as functions. #701 (comment) |
Forward declare the `as` function templates for `std::expected` since they're not found by ADL
Thanks, restored now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp2util.hto supportisandasforstd::expectedpure2-expected-is-asregression testThis replaces the original PR #954; I couldn't successfully rebase it onto the updated changes in
mainso I gave up and created a new PR!CC @filipsajdak
EDIT - The
macOSbuild job is a spurious failure (not found for compiler: 'clang++'). I'm not sure why this happens but I've seen it a few times now. I don't have permission to retry the job in this repo, but in my own fork I just retry the job and it succeeds.EDIT 2 - See PR #972 for the spurious macOS job failure