Merge pull request #88 from paulmelnikow/corser

Get CORS support working with XHR preflight
http-party · Mar 6, 2015 · 630900f · 630900f
2 parents 363d928 + 30f4d1e
commit 630900f
Show file tree

Hide file tree

Showing 4 changed files with 63 additions and 30 deletions.
diff --git a/bin/http-server b/bin/http-server
@@ -70,10 +70,7 @@ function listen(port) {
   };
 
   if (argv.cors) {
-    options.headers = {
-      'Access-Control-Allow-Origin': '*',
-      'Access-Control-Allow-Headers': 'Origin, X-Requested-With, Content-Type, Accept'
-    };
+    options.cors = true;
   }
 
   if (ssl) {

diff --git a/lib/http-server.js b/lib/http-server.js
@@ -2,7 +2,8 @@ var fs = require('fs'),
     util = require('util'),
     union = require('union'),
     ecstatic = require('ecstatic'),
-    httpProxy = require('http-proxy');
+    httpProxy = require('http-proxy'),
+    corser = require('corser');
 
 var HTTPServer = exports.HTTPServer = function (options) {
   options = options || {};
@@ -20,9 +21,7 @@ var HTTPServer = exports.HTTPServer = function (options) {
     }
   }
 
-  if (options.headers) {
-    this.headers = options.headers;
-  }
+  this.headers = options.headers || {};
 
   this.cache = options.cache || 3600; // in seconds.
   this.showDir = options.showDir !== 'false';
@@ -34,37 +33,47 @@ var HTTPServer = exports.HTTPServer = function (options) {
       : options.ext;
   }
 
-  var serverOptions = {
-    before: (options.before || []).concat([
-      function (req, res) {
-        if (options.logFn) {
-          options.logFn(req, res);
-        }
-
-        res.emit('next');
-      },
-      ecstatic({
-        root: this.root,
-        cache: this.cache,
-        showDir: this.showDir,
-        autoIndex: this.autoIndex,
-        defaultExt: this.ext,
-        handleError: typeof options.proxy !== 'string'
-      })
-    ]),
-    headers: this.headers || {}
-  };
+  var before = options.before ? options.before.slice() : [];
+
+  before.push(function (req, res) {
+    if (options.logFn) {
+      options.logFn(req, res);
+    }
+
+    res.emit('next');
+  });
+
+  if (options.cors) {
+    this.headers['Access-Control-Allow-Origin'] = '*';
+    this.headers['Access-Control-Allow-Headers'] = 'Origin, X-Requested-With, Content-Type, Accept';
+
+    before.push(corser.create());
+  }
+
+  before.push(ecstatic({
+    root: this.root,
+    cache: this.cache,
+    showDir: this.showDir,
+    autoIndex: this.autoIndex,
+    defaultExt: this.ext,
+    handleError: typeof options.proxy !== 'string'
+  }));
 
   if (typeof options.proxy === 'string') {
     var proxy = httpProxy.createProxyServer({});
-    serverOptions.before.push(function (req, res) {
+    before.push(function (req, res) {
       proxy.web(req, res, {
         target: options.proxy,
         changeOrigin: true
       });
     });
   }
 
+  var serverOptions = {
+    before: before,
+    headers: this.headers
+  };
+
   if (options.https) {
     serverOptions.https = options.https;
   }

diff --git a/package.json b/package.json
@@ -64,7 +64,8 @@
     "ecstatic": "~0.6.1",
     "http-proxy": "^1.8.1",
     "portfinder": "0.2.x",
-    "opener": "~1.4.0"
+    "opener": "~1.4.0",
+    "corser": "~2.0.0"
   },
   "devDependencies": {
     "vows": "0.7.x",

diff --git a/test/http-server-test.js b/test/http-server-test.js
@@ -114,5 +114,31 @@ vows.describe('http-server').addBatch({
         }
       }
     }
+  },
+  'When cors is enabled': {
+    topic: function () {
+      var server = httpServer.createServer({
+        root: root,
+        cors: true
+      });
+      server.listen(8082);
+      this.callback(null, server);
+    },
+    'and given OPTIONS request': {
+      topic: function () {
+        request({
+          method: 'OPTIONS',
+          uri: 'http://127.0.0.1:8082/',
+          headers: {
+            'Access-Control-Request-Method': 'GET',
+            Origin: 'http://example.com',
+            'Access-Control-Request-Headers': 'Foobar'
+          }
+        }, this.callback);
+      },
+      'status code should be 204': function (err, res, body) {
+        assert.equal(res.statusCode, 204);
+      }
+    }
   }
 }).export(module);