Added option for custom headers #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change --help option output - Accept empty header to conform to RFC 7230 (-H "empty-header" or -H "empty-header:")
This was referenced Sep 23, 2024
KernelDeimos
reviewed
Oct 7, 2024
| }; | ||
|
|
||
| function setHeader(str) { | ||
| const m = /^(.+?)\s*(:\s*(.*))$/.exec(str); |
There was a problem hiding this comment.
note: not re-used, so should be safe from RegExp state caveat
KernelDeimos
reviewed
Oct 7, 2024
| if (argv.cors) { | ||
| options.cors = true; | ||
| if (typeof argv.cors === 'string') { | ||
| options.corsHeaders = argv.cors; | ||
| } | ||
| } | ||
|
|
||
| if (argv.header) { | ||
| if (Array.isArray(argv.header)) { | ||
| argv.header.forEach(h => setHeader(h)); |
There was a problem hiding this comment.
note: I remember reading somewhere that forEach actually has a performance impact over for, but I'm considering that an unnecessary optimization and not requiring any change here.
|
Looks good, merging this - thanks! I've opened #899 for continued discussion before this goes into a release. |
|
Tests are failing. Also mentioned this in the aforementioned discussion; please respond in the discussion rather than here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difference/improvements over #885:
curl -Handcurl --header1Sorry :)
Relevant issues
Resolves #884
Contributor checklist
--helpoutputmasterbranchMaintainer checklist
Footnotes
https://curl.se/docs/manpage.html#-H ↩