Properly write response header optionally including statusMessage #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcanoxDragon
pushed a commit
to ArcanoxDragon/harmon
that referenced
this pull request
Sep 14, 2016
…calls response.writeHead. This version can be relaxed once http-party/node-http-proxy#1061 is accepted and a new version is published.
|
@briman0094 @No9 would love a harmon test so this type of breakage could be prevented in the future. Thanks for the contribution! |
lolychee
added a commit
to lolychee/node-http-proxy
that referenced
this pull request
Oct 4, 2016
…sage (http-party#1061)" This reverts commit 8408720.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-adds the call to writeHead in web-outgoing so that other middleware which depend on or patch the response.writeHead method (such as harmon) don't break.
Depends on No9/harmon#38 being accepted