Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override connection header if Upgrading #640

Merged
merged 2 commits into from
May 10, 2014

Conversation

jayharris
Copy link
Contributor

As a patch to #488, do not override the connection header to 'close' if we are upgrading. Always overriding to 'close' prevents upgrades on agent-less sockets, as the proxy destination will never receive the upgrade request. With this change, we leave 'upgrade' requests alone, and let them do their thing.

This also addresses #638.

@jcrugzz
Copy link
Contributor

jcrugzz commented May 10, 2014

@jayharris mind adding a test case for this? But thanks for the contribution!

@jayharris
Copy link
Contributor Author

@jcrugzz Done.

@jayharris
Copy link
Contributor Author

Not quite sure why Travis fails. It is green, locally.

@jcrugzz
Copy link
Contributor

jcrugzz commented May 10, 2014

@jayharris awesome thanks! Tests are failing due to SSL things on 0.11.x.

jcrugzz added a commit that referenced this pull request May 10, 2014
Don't override connection header if Upgrading
@jcrugzz jcrugzz merged commit 896ee7c into http-party:master May 10, 2014
@jayharris
Copy link
Contributor Author

Sweet! Any chance of this PR warranting a push to NPM? I have a few issues on @linemanjs that I'm trying to get closed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants