Added proxyTimeout option and two tests for timeout #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis shows it's testing properly on Node 0.10 which is better than what I encountered. :-) |
Rush
changed the title
|
@jcrugzz Changed the naming according to your comment. |
|
@RushPL thanks! |
jcrugzz
added a commit
that referenced
this pull request
Jun 10, 2014
Added proxyTimeout option and two tests for timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the new option would allow
http-masterto show a custom timeout page instead of simply hanging up the socket. The default timeout option is still there. I have added test for both cases since there was no test for the timeout at all. This feature has been tested on the application level so looks ok.