Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tests to expose sequencing bugs #180

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Diggsey
Copy link
Contributor

@Diggsey Diggsey commented Feb 2, 2021

Regarding the addition of a sleep to accept_one:

This is used by the test_accept_partial_read_sequential_requests test to make it easier to reproduce the problem. Hopefully you agree that such a delay could naturally occur in a complex program given the surrounding async operations, and that if introducing a delay here causes a problem, then the code already had a bug. If not, then ignore that test.

Identical tests have been added to #179 to show that it fixes these issues.

@Diggsey
Copy link
Contributor Author

Diggsey commented Mar 4, 2021

@yoshuawuyts did you have a chance to review these test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant