Remove HMAC and switch to Authorization #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Jun 23, 2023
|
|
||
| # Authentication Parameters | ||
|
|
||
| This specification defines the following authentication parameters, they can be | ||
| used by the authentication schemes defined in {{schemes}}. | ||
| This specification defines the following authentication parameters: |
There was a problem hiding this comment.
You are using structured fields for the definitions of these, even though Authorization doesn't use SF. That's good, but I might take this opportunity to make this point.
There was a problem hiding this comment.
I think I agree with the idea but I'm not sure I see what you mean. Do you have thoughts on how best to make said point?
There was a problem hiding this comment.
"These parameters use SF [RFC8941 (or -bis)] in their definition, though the Authorization field does not use SF."
This was referenced Jun 24, 2023
chris-wood
approved these changes
Jun 26, 2023
chris-wood
reviewed
Jun 26, 2023
Co-authored-by: Christopher Wood <caw@heapingbits.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2440
Fixes #2432