Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the compression window sizes for zstd-d and br-d #2769

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Apr 3, 2024

This change makes it explicit that the zstd-d content encoding is Zstandard with up to a 8 MB compression window (same as zstd) and br-d is Brotli with up to a 16 MB compression window (same as br).

See the discussion in #2754 for why larger ZStandard values were not selected.

This carries some nuance for what encoding to use when compressing for maximum benefit as the resource size crosses beyond 8 MB but that is more of an editorial discussion about the individual compression algorithms and probably better laid out in blog posts or explainers than in the spec.

Fix #2754

@pmeenan
Copy link
Contributor Author

pmeenan commented Apr 3, 2024

@nidhijaju could you PTAL and make sure the language matches what you're working on for the zstd update?

draft-ietf-httpbis-compression-dictionary.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-compression-dictionary.md Outdated Show resolved Hide resolved
@pmeenan
Copy link
Contributor Author

pmeenan commented Apr 4, 2024

Thanks. I switched the content-encodings definitions and IANA registrations to a list with references back to the algorithm RFCs. For the IANA registrations I removed the window size from the text and linked it to this document (where the window sizes are defined) instead of to the compression algorithms directly.

Let me know if a more verbose description of the need to specify the window sizes would be useful or if just being explicit about what they are is enough.

Copy link
Contributor

@nidhijaju nidhijaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the comment

draft-ietf-httpbis-compression-dictionary.md Outdated Show resolved Hide resolved
@pmeenan pmeenan merged commit 64e642b into httpwg:main Apr 8, 2024
1 check passed
@pmeenan pmeenan deleted the window branch April 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Window Size for Shared Dictionary Content Encodings
3 participants