Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get commit or tag signature verified flag #737

Closed
sourabhsparkala opened this issue Mar 12, 2020 · 1 comment · Fixed by #738
Closed

Get commit or tag signature verified flag #737

sourabhsparkala opened this issue Mar 12, 2020 · 1 comment · Fixed by #738

Comments

@sourabhsparkala
Copy link
Contributor

It is observed that some commits/tags are verified by user signature. Depending on this signature authorization. A verified flag is set to true/false.

Request to add this as a feature request. Such that when we collect individual commit or tag information. We get an associated signature verified flag as well.

For more details please check here.

sourabhsparkala added a commit to sourabhsparkala/github-api that referenced this issue Mar 12, 2020
This fixes hub4j#737
1. A new entity GHVerification.java has been added which would be reflecting Verification flag.
2. Updating GHCommit.java and GHTagObject.java with GHVerification.
3. Altering few test cases AppTest.java and GHTagTest.java to verify if the Verification entity is being picked up.
sourabhsparkala added a commit to sourabhsparkala/github-api that referenced this issue Mar 12, 2020
This fixes hub4j#737

1. A new entity GHVerification.java has been added which would be reflecting Verification flag.
2. Updating GHCommit.java and GHTagObject.java with GHVerification.
3. Altering few test cases AppTest.java and GHTagTest.java to verify if the Verification entity is being picked up.
4. A separate test class SignatureVerificationTest.java with the associated wiremock test resources
sourabhsparkala added a commit to sourabhsparkala/github-api that referenced this issue Mar 25, 2020
This fixes hub4j#737

- A new entity GHVerification.java has been added which would be reflecting Verification flag
- Updating GHCommit.java and GHTagObject.java with GHVerification
- Altering few test cases AppTest.java and GHTagTest.java to verify if the Verification entity is being picked up
- A separate test class SignatureVerificationTest.java with the associated wiremock test resources
- Adding a new enum GHReason.java
- Updating tests to check the GHReason implementation, GHReasonTest.java with the associated wiremock test resources
sourabhsparkala added a commit to sourabhsparkala/github-api that referenced this issue Mar 25, 2020
This fixes hub4j#737

- A new entity GHVerification.java has been added which would be reflecting Verification flag
- Updating GHCommit.java and GHTagObject.java with GHVerification
- Altering few test cases AppTest.java and GHTagTest.java to verify if the Verification entity is being picked up
- A separate test class SignatureVerificationTest.java with the associated wiremock test resources
- Adding a new enum GHReason.java
- Updating tests to check the GHReason implementation, GHReasonTest.java with the associated wiremock test resources
@sourabhsparkala
Copy link
Contributor Author

@bitwiseman would it be part of 1.109 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants