Add support for oauth token and a way to see my organizations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires some changes as there is no login and password but instead a token at a certain priviledge level.
Add JsonOrganizations to support getting a list of my organizations. Because Github.login is needed we fetch it during the Github.connectUsingOAuth() method.
|
Thanks for the change! Merged and released 1.10. I also set you up with the push access. |
|
Thanks. I think you still have to release the 1.10 version inside the oss.sonatype.org management interface. At first I thought the artifact hadn't sync'd into central but searching for github-api doesn't show the 1.10 version either: |
kohsuke
pushed a commit
that referenced
this pull request
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written a github oauth authentication plugin for jenkins and I used github-api for the interactions with github once I have the token.
My first pass implementation of the plugin works so I want to contribute the github-api changes back.
Changes: