Code Coverage update #1022
Merged
Code Coverage update #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
force-pushed
the
task/enum-coverage
branch
2 times, most recently
from
db92ee4
to
4e08b71
Compare
bitwiseman
force-pushed
the
task/enum-coverage
branch
from
4e08b71
to
33109f0
Compare
This change adds or update a swath of tests to push method code coverage numbers up. Yes, method coverage is not super meaningful, but it is one metric that we can use to ensure at least minimal coverage of this library. Almost no product changes in here.
bitwiseman
force-pushed
the
task/enum-coverage
branch
from
33109f0
to
35c8cfa
Compare
bitwiseman
commented
Jan 25, 2021
Comment on lines
+575
to
+576
| <!-- Only fail code coverage on non-windows machines --> | ||
| <jacoco.haltOnFailure>true</jacoco.haltOnFailure> |
There was a problem hiding this comment.
Rather than exclude some classes from measurement due to tests not running on windows, don't run coverage on windows.
bitwiseman
commented
Jan 25, 2021
Comment on lines
+23
to
+26
|
|
||
| GitHub getRoot() { | ||
| return root; | ||
| } |
There was a problem hiding this comment.
Added this internal method for tests to use, in preparation changing root to private.
bitwiseman
commented
Jan 25, 2021
| @@ -192,8 +205,7 @@ public GHPullRequestReviewComment reply(String body) throws IOException { | |||
| return owner.root.createRequest() | |||
| .method("POST") | |||
| .with("body", body) | |||
| .with("in_reply_to", getId()) | |||
| .withUrlPath(getApiRoute() + "/comments") | |||
| .withUrlPath(getApiRoute(true) + "/replies") | |||
There was a problem hiding this comment.
This is the only real product change. Bug fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to raise the minimum bar for coverage to 50%
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: