-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support make_latest when creating/updating a release #1676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is an api to the the latest release, example: https://api.github.com/repos/hub4j/github-api/releases/latest
.
I've invited you to https://github.com/hub4j-test-org to make creating the test easier.
So, you could write a test that:
- Creates a temp repository (built-in utility)
- Creates a release
- Gets latest (should match the created release)
- Creates a new release with
make_latest
set tofalse
- Gets latest (should match the first release)
- Creates a new release with
make_latest
set totrue
- Gets latest (should match the last created release)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
============================================
+ Coverage 79.97% 80.00% +0.02%
- Complexity 2221 2223 +2
============================================
Files 213 213
Lines 6718 6727 +9
Branches 365 365
============================================
+ Hits 5373 5382 +9
Misses 1131 1131
Partials 214 214
☔ View full report in Codecov by Sentry. |
Description
Add support for the
make_latest
option when creating or updating a release (https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release).Fixes #1595.
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: