Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support team, team_add, member and membership payloads #1818
Support team, team_add, member and membership payloads #1818
Changes from 1 commit
d629eaf
f7a7777
ee25c39
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1868 in src/main/java/org/kohsuke/github/GHEventPayload.java
Codecov / codecov/patch
src/main/java/org/kohsuke/github/GHEventPayload.java#L1868
Check warning on line 1874 in src/main/java/org/kohsuke/github/GHEventPayload.java
Codecov / codecov/patch
src/main/java/org/kohsuke/github/GHEventPayload.java#L1874
Check warning on line 1916 in src/main/java/org/kohsuke/github/GHEventPayload.java
Codecov / codecov/patch
src/main/java/org/kohsuke/github/GHEventPayload.java#L1916
Check warning on line 1922 in src/main/java/org/kohsuke/github/GHEventPayload.java
Codecov / codecov/patch
src/main/java/org/kohsuke/github/GHEventPayload.java#L1922
Check warning on line 1996 in src/main/java/org/kohsuke/github/GHEventPayload.java
Codecov / codecov/patch
src/main/java/org/kohsuke/github/GHEventPayload.java#L1996
Check warning on line 2002 in src/main/java/org/kohsuke/github/GHEventPayload.java
Codecov / codecov/patch
src/main/java/org/kohsuke/github/GHEventPayload.java#L2002
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet
Ugh. The events api is all over the place. The
added
action has arole_name
and states thatpermission
is obsolete. But theedited
action haspermission
andold_permission
, with no note about either of those being obsolete. And they both are returned under thechanges
parameter.https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=added#member
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=edited#member
I guess this class is okay. It is incomplete, but the other fields can be added later without causing a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some tests for permission and old_permission wasn’t there.
I need to check for role_name though. I will have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah so that's what I thought,
role_name
wasn't in the payload I obtained...They might change it at some point, I don't know. I'll have a look at adding
role_name
for a future version but it's going to be untested.