Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iterator.remove() #718

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

bitwiseman
Copy link
Member

Description

We don't need to implement Iterator.remove().

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.

@bitwiseman bitwiseman force-pushed the task/iterator-remove branch 2 times, most recently from fe436c0 to e10a64e Compare February 25, 2020 03:33
@bitwiseman bitwiseman merged commit b5c7f83 into hub4j:master Feb 25, 2020
@bitwiseman bitwiseman deleted the task/iterator-remove branch February 25, 2020 04:30
@bitwiseman bitwiseman changed the title Task/iterator remove Remove iterator.remove() Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant