Enable injection of GitHub and other values into mapping #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
commented
Feb 27, 2020
| @@ -43,7 +57,7 @@ | |||
| * the io exception | |||
| */ | |||
| public GHUser getOwner() throws IOException { | |||
| return root.intern(owner); | |||
| return owner; | |||
There was a problem hiding this comment.
owner is alway interned during construction now.
bitwiseman
commented
Feb 27, 2020
Comment on lines
-145
to
-166
| GHGist wrapUp(GHUser owner) { | ||
| this.owner = owner; | ||
| this.root = owner.root; | ||
| wrapUp(); | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Used when caller obtains {@link GHGist} without knowing its owner. A partially constructed owner object is | ||
| * interned. | ||
| */ | ||
| GHGist wrapUp(GitHub root) { | ||
| this.owner = root.getUser(owner); | ||
| this.root = root; | ||
| wrapUp(); | ||
| return this; | ||
| } | ||
|
|
||
| private void wrapUp() { | ||
| for (Entry<String, GHGistFile> e : files.entrySet()) { | ||
| e.getValue().fileName = e.getKey(); | ||
| } |
There was a problem hiding this comment.
Actions that were being done after instantiation are now done in the constructor, allowing for those values to be final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progress on #599. While there will alway be a need for late binding in some scenarios, binding of
GitHubreference can always be done during mapping. Other actions that were being done after mapping can also sometimes be done during mapping by using a constructor. Values not initialized in the constructor are bound via reflection as they always were.Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.