-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make getTeambySlug faster #733
Conversation
To fix test I would need access to https://github.com/github-api-test-org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need updates to tests and auto-formatting. Thanks!
Invited to test org. 😄 |
Co-Authored-By: Liam Newman <bitwiseman@gmail.com>
@bitwiseman Thanks for org invite.. now will be easier with tests.. |
|
||
GHTeam teamById = gitHub.getTeam(teamByName.getId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just because it is deprecated doesn't mean we can remove the test for it. We must ensure it continues to work until it is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more test change and then i can merge. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fast turnaround.
Description
Change method how
getTeambySlug
works... (direct api call instead of getting list and iterating)Wit bigger organisations getting all teams can take a lot of times..
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master
. Create your PR from that branch.mvn -D enable-ci clean install site
locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.